Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lan Lobby Window Layout Update (ControlBarPro Merge & UI Symmetry Fix) #2576

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DevGeniusCode
Copy link
Collaborator

@DevGeniusCode DevGeniusCode commented Jan 5, 2025

The element layout in the Lan Lobby window has been updated, including the merge of the ControlBarPro version and symmetrical adjustments.

Currently, there are 3 layout proposals for the element positioning in the window, created due to a bug in the UI engine that prevents scrolling the room list. Any change in the list refreshes it, causing it to jump back to the top, making scrolling impossible.

The three proposals are:

  • Original Version: The drawback is that the list is short, and only up to 10 rooms are visible without scrolling.
    LanLobbyMenu wnd

  • ControlBarPro Version: The layout was adjusted while maintaining the game’s design principles, and now 28 rooms can be seen without scrolling.
    lanLobby_800x600_PRO

  • FAS Version: It covers the entire screen and displays 33 rooms without scrolling.
    lanLobby_800x600_FAS

These changes are based on a 800x600 resolution and LabelRegular font at size 10.

Given this, it is suggested to switch to LabelSmall font at size 8 to allow more rooms to be visible without scrolling. With the smaller font, 32 rooms are visible without scrolling.

Regarding the scrolling bug TheSuperHackers/GeneralsGameCode#201 , after reviewing various mods, no successful solution has been found, and it is likely that the issue needs to be addressed at the game’s core engineering level.

Additional Notes:

  • The adjustments and symmetry fixes were made specifically for the 800x600 resolution.
  • The space for the map name has been extended to accommodate longer map names.
  • The player list in the game was extended to show all players without scrolling. However, the 8th player is still partially hidden, and in higher resolutions, empty space is displayed. The preferable approach has not yet been determined.
  • The Main Menu button has been moved to the button list for design consistency.

lanLobby_800x600_Fixed

@DevGeniusCode
Copy link
Collaborator Author

I also suggest this layout which follows the flow of actions: Players -> Games-> Game Info, similar to the original layout.
lanLobby_800x600_Fixed - Copy

@xezon
Copy link
Collaborator

xezon commented Jan 7, 2025

It looks quite cramped but I currently have no better ideas. The buttons and list boxes seem very close to the border. Btw (the original) Control Bar Pro does not have a custom Network lobby.

@xezon xezon added Design Is a matter of game design Minor Severity: Minor < Major < Critical < Blocker GUI For graphical user interface labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Is a matter of game design GUI For graphical user interface Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants